-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded github.com/hashicorp/go-slug v0.16.0 => v0.16.3 #1025
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 1421 Passed, 159 Skipped, 17m 20.55s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I requested an update in the changelog. But otherwise this looks good!
@@ -6,6 +6,10 @@ | |||
* Add BETA support for Linux arm64 agents, which is EXPERIMENTAL, SUBJECT TO CHANGE, and may not be available to all users @natalie-todd [#1022](https://github.com/hashicorp/go-tfe/pull/1022) | |||
* Adds support to delete all tag bindings on either a project or workspace by @sebasslash [#1023](https://github.com/hashicorp/go-tfe/pull/1023) | |||
|
|||
## Bug Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this branch is out of date. We released 1.72.0 yesterday. This new item should go under the "unreleased" section, which will on top of # v1.72.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @uturunku1. I addressed your request in 6baf42d.
Looking on the repo landing page, is there a reason why you not adjusted the latest release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops! Thanks for making me notice. I probably didn't mark the checkbox that set a new release as the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have approved your PR. Feel free to merge whenever you are ready @NodyHub ! Also feel reach out in my team's channel , so we can speed up the release process if needed. We normally do a release on Tuesdays. But we can make exceptions if there is an urgency.
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Dependency update from go-slug to upstream latest adjustments.
Testing plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.