Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded github.com/hashicorp/go-slug v0.16.0 => v0.16.3 #1025

Merged
merged 4 commits into from
Jan 10, 2025
Merged

upgraded github.com/hashicorp/go-slug v0.16.0 => v0.16.3 #1025

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68a78aa
upgraded github.com/hashicorp/go-slug v0.16.0 => v0.16.3
NodyHub Jan 7, 2025
106dfd2
remove deprecated feature
NodyHub Jan 7, 2025
8ad38db
Merge branch 'main' into nodyhub/update-go-slug
NodyHub Jan 9, 2025
6baf42d
adjusted targeted release in the changelog
NodyHub Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
* Add BETA support for Linux arm64 agents, which is EXPERIMENTAL, SUBJECT TO CHANGE, and may not be available to all users @natalie-todd [#1022](https://github.com/hashicorp/go-tfe/pull/1022)
* Adds support to delete all tag bindings on either a project or workspace by @sebasslash [#1023](https://github.com/hashicorp/go-tfe/pull/1023)

## Bug Fixes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this branch is out of date. We released 1.72.0 yesterday. This new item should go under the "unreleased" section, which will on top of # v1.72.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @uturunku1. I addressed your request in 6baf42d.

Looking on the repo landing page, is there a reason why you not adjusted the latest release?
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Thanks for making me notice. I probably didn't mark the checkbox that set a new release as the latest.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved your PR. Feel free to merge whenever you are ready @NodyHub ! Also feel reach out in my team's channel , so we can speed up the release process if needed. We normally do a release on Tuesdays. But we can make exceptions if there is an urgency.


* Update dependency `github.com/hashicorp/go-slug` `v0.16.0` => `v0.16.3` to integrate latest changes.

# v1.71.0

## Enhancements
Expand Down
1 change: 0 additions & 1 deletion configuration_version_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,6 @@ func TestConfigurationVersionsUploadTarGzip(t *testing.T) {
packer, err := slug.NewPacker(
slug.DereferenceSymlinks(),
slug.ApplyTerraformIgnore(),
slug.AllowSymlinkTarget("/target/symlink/path/foo"),
)
require.NoError(t, err)

Expand Down
10 changes: 4 additions & 6 deletions example_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,8 @@ func ExampleConfigurationVersions_UploadTarGzip() {
}

packer, err := slug.NewPacker(
slug.DereferenceSymlinks(), // dereferences symlinks
slug.ApplyTerraformIgnore(), // ignores paths specified in .terraformignore
slug.AllowSymlinkTarget("/some/path"), // allow certain symlink target paths
slug.DereferenceSymlinks(), // dereferences symlinks
slug.ApplyTerraformIgnore(), // ignores paths specified in .terraformignore
)
if err != nil {
log.Fatal(err)
Expand Down Expand Up @@ -131,9 +130,8 @@ func ExampleRegistryModules_UploadTarGzip() {
}

packer, err := slug.NewPacker(
slug.DereferenceSymlinks(), // dereferences symlinks
slug.ApplyTerraformIgnore(), // ignores paths specified in .terraformignore
slug.AllowSymlinkTarget("/some/path"), // allow certain symlink target paths
slug.DereferenceSymlinks(), // dereferences symlinks
slug.ApplyTerraformIgnore(), // ignores paths specified in .terraformignore
)
if err != nil {
log.Fatal(err)
Expand Down
5 changes: 2 additions & 3 deletions examples/configuration_versions/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ func main() {
}

packer, err := slug.NewPacker(
slug.DereferenceSymlinks(), // dereferences symlinks
slug.ApplyTerraformIgnore(), // ignores paths specified in .terraformignore
slug.AllowSymlinkTarget("/some/path"), // allow certain symlink target paths
slug.DereferenceSymlinks(), // dereferences symlinks
slug.ApplyTerraformIgnore(), // ignores paths specified in .terraformignore
)
if err != nil {
log.Fatal(err)
Expand Down
5 changes: 2 additions & 3 deletions examples/registry_modules/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ func main() {
}

packer, err := slug.NewPacker(
slug.DereferenceSymlinks(), // dereferences symlinks
slug.ApplyTerraformIgnore(), // ignores paths specified in .terraformignore
slug.AllowSymlinkTarget("/some/path"), // allow certain symlink target paths
slug.DereferenceSymlinks(), // dereferences symlinks
slug.ApplyTerraformIgnore(), // ignores paths specified in .terraformignore
)
if err != nil {
log.Fatal(err)
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
github.com/google/go-querystring v1.1.0
github.com/hashicorp/go-cleanhttp v0.5.2
github.com/hashicorp/go-retryablehttp v0.7.7
github.com/hashicorp/go-slug v0.16.0
github.com/hashicorp/go-slug v0.16.3
github.com/hashicorp/go-uuid v1.0.3
github.com/hashicorp/go-version v1.7.0
github.com/hashicorp/jsonapi v1.3.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ github.com/hashicorp/go-cleanhttp v0.5.2/go.mod h1:kO/YDlP8L1346E6Sodw+PrpBSV4/S
github.com/hashicorp/go-hclog v1.6.3 h1:Qr2kF+eVWjTiYmU7Y31tYlP1h0q/X3Nl3tPGdaB11/k=
github.com/hashicorp/go-retryablehttp v0.7.7 h1:C8hUCYzor8PIfXHa4UrZkU4VvK8o9ISHxT2Q8+VepXU=
github.com/hashicorp/go-retryablehttp v0.7.7/go.mod h1:pkQpWZeYWskR+D1tR2O5OcBFOxfA7DoAO6xtkuQnHTk=
github.com/hashicorp/go-slug v0.16.0 h1:S/ko9fms1gf6305ktJNUKGxFmscZ+yWvAtsas0SYUyA=
github.com/hashicorp/go-slug v0.16.0/go.mod h1:THWVTAXwJEinbsp4/bBRcmbaO5EYNLTqxbG4tZ3gCYQ=
github.com/hashicorp/go-slug v0.16.3 h1:pe0PMwz2UWN1168QksdW/d7u057itB2gY568iF0E2Ns=
github.com/hashicorp/go-slug v0.16.3/go.mod h1:THWVTAXwJEinbsp4/bBRcmbaO5EYNLTqxbG4tZ3gCYQ=
github.com/hashicorp/go-uuid v1.0.3 h1:2gKiV6YVmrJ1i2CKKa9obLvRieoRGviZFL26PcT/Co8=
github.com/hashicorp/go-uuid v1.0.3/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
github.com/hashicorp/go-version v1.7.0 h1:5tqGy27NaOTB8yJKUZELlFAS/LTKJkrmONwQKeRZfjY=
Expand Down
1 change: 0 additions & 1 deletion registry_module_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1763,7 +1763,6 @@ func TestRegistryModulesUploadTarGzip(t *testing.T) {
packer, err := slug.NewPacker(
slug.DereferenceSymlinks(),
slug.ApplyTerraformIgnore(),
slug.AllowSymlinkTarget("/target/symlink/path/foo"),
)
require.NoError(t, err)

Expand Down
Loading