fix(stacks/vcs): StackVCSRepo nested-struct incorrectly serializing attributes #1029
+21
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 1421 Passed, 159 Skipped, 19m 19.89s Total Time |
…ttributes hashicorp/jsonapi and by extension google/jsonapi packages have issues serializing nested-structs that are not relationship, but attr. Converting to json struct tag directive for the time being .
mjyocca
force-pushed
the
mjyocca/stacks-debug-github-app-install-empty
branch
from
4ffa880 to
4d060ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hashicorp/jsonapi and by extension google/jsonapi packages have issues serializing nested-structs that are not
relationship, butattr. Converting to json struct tag directive for the time being.Example JSON being serialized currently
{ "attributes": { "vcs-repo": { "Branch": "main", // should be: `branch` "Identifier": "", // should be: `identifier` "GHAInstallationID": "ghai-*********", // should be: `github-app-instllation-id` "OAuthTokenID": "", // should be: `oauth-token-id` } } }Testing plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.