Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-23277] Fix archs field in terraform-versions CREATE request #1030

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

natalie-todd
Copy link
Contributor

Description

This PR fixes the formatting of the archs param in the terraform-versions CREATE request. It is for the Beta of arm64 arch support for agents.

External links

@natalie-todd natalie-todd requested a review from a team as a code owner January 9, 2025 22:21
@natalie-todd natalie-todd force-pushed the ntodd/tf-23277/fix-arm-formatting-in-req branch from 9fad112 to 892295f Compare January 9, 2025 22:22
@natalie-todd natalie-todd requested a review from radditude January 9, 2025 22:38
@natalie-todd natalie-todd force-pushed the ntodd/tf-23277/fix-arm-formatting-in-req branch from 892295f to d43e667 Compare January 9, 2025 22:53
@datadog-terraform-cloud-hashicorp
Copy link

datadog-terraform-cloud-hashicorp bot commented Jan 9, 2025

Datadog Report

Branch report: ntodd/tf-23277/fix-arm-formatting-in-req
Commit report: c3256bd
Test service: hashicorp/go-tfe

✅ 0 Failed, 1421 Passed, 159 Skipped, 17m 35.98s Total Time
➡️ Test Sessions change in coverage: 1 no change

@natalie-todd natalie-todd requested a review from radditude January 9, 2025 23:14
radditude
radditude previously approved these changes Jan 10, 2025
Copy link
Member

@radditude radditude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, pending Brandon's review!

@natalie-todd natalie-todd requested a review from brandonc January 10, 2025 00:36
brandonc
brandonc previously approved these changes Jan 10, 2025
@natalie-todd natalie-todd merged commit 220fbfa into main Jan 10, 2025
7 checks passed
@natalie-todd natalie-todd deleted the ntodd/tf-23277/fix-arm-formatting-in-req branch January 10, 2025 18:35
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants