TF-9651 update varset enforced attribute to priority attribute #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netra2104
previously approved these changes
Oct 3, 2023
Uk1288
reviewed
Oct 10, 2023
CHANGELOG.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| <!-- Please also include if this is a Bug Fix, Enhancement, or Feature --> | |||
|
|
|||
| ## Enhancements | |||
| * Added BETA support for including `enforced` attribute to variable_set on create and update by @Netra2104 [#778](https://github.com/hashicorp/go-tfe/pull/778) | |||
| * Added BETA support for including `priority` attribute to variable_set on create and update by @Netra2104 [#778](https://github.com/hashicorp/go-tfe/pull/778) | |||
There was a problem hiding this comment.
Looks like go-tfe was already released with the name enforced: https://github.com/hashicorp/go-tfe/releases/tag/v1.35.0.
Is this right?
If this is the case we may need to make the update to priority backward compatibility so user code doesn't break after upgrade.
There was a problem hiding this comment.
Had discussions and turns out it can be renamed without backward compatibility since the field is marked BETA.
Uk1288
approved these changes
Oct 24, 2023
rberecka
deleted the
TF-9651-update-varsets-enforced-field-to-priority-field
branch
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename the enforced field on varsets to be priority instead. This feature has not been released yet anywhere, so there's no concern about breaking changes here.
This pr simply renames the field added in this PR by @Netra2104: #778
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.