TF-9268 Add support for POST/DELETE oauth_client/:id/relationships/projects #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netra2104
force-pushed
the
Netra2104/TF-9268-post-delete-oauth-api
branch
from
d047a02 to
87f5a92
Compare
Netra2104
force-pushed
the
Netra2104/TF-9268-post-delete-oauth-api
branch
2 times, most recently
from
0084885 to
b6ecdc9
Compare
brandonc
previously approved these changes
Nov 15, 2023
| @@ -384,6 +427,140 @@ func TestOAuthClientsCreateOptionsValid(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestOAuthClientsAddProjects(t *testing.T) { | |||
| skipUnlessBeta(t) | |||
There was a problem hiding this comment.
I think it should be possible to remove skipUnlessBeta calls from your new tests because these endpoints are not behind a feature flag and the tests can be run.
There was a problem hiding this comment.
@Netra2104 It seems like my suggestion was a bad one. It usually takes a day for the test infrastructure to catch up with the platform nightly release. I take it that the 'Remove' endpoint was added today?
There was a problem hiding this comment.
Ohhhhh sorry about that; I didn't notice.
added the project relationship and the post/delete support removed include changelog read with options generate mocks readWithOptions test Update CHANGELOG.md rename
Netra2104
force-pushed
the
Netra2104/TF-9268-post-delete-oauth-api
branch
from
a9064fa to
c5faa19
Compare
brandonc
approved these changes
Nov 15, 2023
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users should be able to add/remove projects using POST/DELETE oauth_clients/:id/relationships/projects in the oauth_client resource.
Testing plan
Integration test is added to complete the testing plan. The tests are currently set to beta but can be tested locally by removing the beta flag and running the tests.
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.