-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WorkspaceResources interface and List method #820
feat: WorkspaceResources interface and List method #820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for making the contribution. I only found one very small tweak. What's really surprising is that the README says that the resource is available when it was, in fact, not.
Provider string `jsonapi:"attr,provider"` | ||
ProviderType string `jsonapi:"attr,provider-type"` | ||
ModifiedByStateVersionID string `jsonapi:"attr,modified-by-state-version-id"` | ||
NameIndex string `jsonapi:"attr,name-index"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this field type a *string
to reflect the fact that it can be null
?
@stefan-kiss We're actually prepping a release right now so I'm going to bring your commits into the repo and add the quick change I recommended. |
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
sorry, i missed the earlier comments but yes, it's perfectly fine. didnt realise it could be null :) anyway glad it was merged & thank you! |
Description
Implementing missing Workspace Resources api
Testing plan
External links
Output from tests