[TF-10829] add new organization setting option #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjyocca
force-pushed
the
mjyocca/TF-10829
branch
2 times, most recently
from
d855e08 to
5521b56
Compare
brandonc
previously approved these changes
Jan 17, 2024
mjyocca
force-pushed
the
mjyocca/TF-10829
branch
from
ba73bfc to
d78cde0
Compare
brandonc
requested changes
Jan 17, 2024
organization.go
Outdated
| @@ -213,6 +215,9 @@ type OrganizationCreateOptions struct { | |||
| // Optional: SendPassingStatusesForUntriggeredSpeculativePlans toggles behavior of untriggered speculative plans to send status updates to version control systems like GitHub. | |||
| SendPassingStatusesForUntriggeredSpeculativePlans *bool `jsonapi:"attr,send-passing-statuses-for-untriggered-speculative-plans,omitempty"` | |||
|
|
|||
| // Optional: If enabled, SendPassingStatusesForUntriggeredSpeculativePlans needs to be false. | |||
| AggregatedCommitStatusEnabled *bool `jsonapi:"attr,aggregated-commit-status-enabled"` | |||
There was a problem hiding this comment.
Oh, these Update/Create options should continue to be omitempty, because in this case the empty (nil) pointer omits the attribute!
mjyocca
force-pushed
the
mjyocca/TF-10829
branch
from
d78cde0 to
c6bfc1f
Compare
brandonc
previously approved these changes
Jan 17, 2024
mjyocca
force-pushed
the
mjyocca/TF-10829
branch
from
c6bfc1f to
9a72fd3
Compare
lilincmu
approved these changes
Jan 18, 2024
brandonc
approved these changes
Jan 18, 2024
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new Organization field to expose enablement/disablement of the new VCS status check setting.
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.