Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update the Plans API to be able to fetch & return resource changes #854

Closed
wants to merge 4 commits into from

Conversation

AhmedRaafat14
Copy link

Description

This adds a new function to the Plans API (ReadResourceChanges) that takes a PlanID and return a list of all resource changes done by the target plan.

Testing plan

External links

Output from tests

@AhmedRaafat14 AhmedRaafat14 requested a review from a team as a code owner February 14, 2024 09:58
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 14, 2024

CLA assistant check
All committers have signed the CLA.

@brandonc
Copy link
Collaborator

Hey, @AhmedRaafat14, thanks for the contribution. Unfortunately, we've made a conscious decision not to include this endpoint in our public API in order to reserve the right to change it or break it in the future. Including it here would link it to the stability guarantees implied by the go-tfe version. Furthermore, the profuse interface{} types limit the utility of the public types anyway.

I don't discourage you from using this endpoint! I would just try to isolate it in your code as "internal HashiCorp API that isn't covered by their stability policy"

@brandonc brandonc closed this Feb 14, 2024
@AhmedRaafat14
Copy link
Author

Hi @brandonc thanks for your reply and these information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants