Add sort field to workspace list options #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maed223
force-pushed
the
add-sort-field-workspace-list-options
branch
from
80718fe to
e06fcf8
Compare
Maed223
force-pushed
the
add-sort-field-workspace-list-options
branch
from
e5b9eb8 to
c43f037
Compare
brandonc
requested changes
Feb 26, 2024
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
Sortquery parameter toWorkspaceListOptions. Was previously present inAdminWorkspaceListOptionsbut was missing inWorkspaceListOptionsdespite the two endpoints having an identical sort behavior, implemented by the same service object class in atlas.OTHER NOTE: Added a greater degree of specificity to the test covering
Sort'screated-atbehavior for the admin side of things.Testing plan
Tests covering this
Sortbehavior have been added toworkspace_integration_test.go.External links
Jira Ticket
Output from tests