Remove OAuth Client Beta Flag #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker-an
approved these changes
Apr 22, 2024
| assert.Equal(t, ps.Name, *options.Name) | ||
| assert.Equal(t, len(ps.Projects), 1) | ||
| assert.Equal(t, ps.Projects[0].ID, prjTest.ID) | ||
| }) |
There was a problem hiding this comment.
I couldn't tell but does this test already exist somewhere else and that's why we're deleting it completely and not just line 180?
There was a problem hiding this comment.
No, this test actually doesn't make sense and won't pass since the projects attribute was added to the add projects and remove projects api only.
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once the feature flag in atlas (project-scoped-vcs) has been removed, this PR will remove the beta flags.
Testing plan
The integration tests should pass.
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.