Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Organization Scoped a pointer #884

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

netramali
Copy link
Contributor

@netramali netramali commented Apr 11, 2024

Description

Making organization scoped a pointer so that in provider when the api is not available, the value is shown as nil. Else, the true value would be confusing, if its is false or nil.

Testing plan

Smoke test

External links

Output from tests

--- PASS: TestOAuthClientsUpdate (2.90s)
=== RUN   TestOAuthClientsUpdate/updates_organization_scoped
    --- PASS: TestOAuthClientsUpdate/updates_organization_scoped (0.71s)
PASS

@netramali netramali marked this pull request as ready for review April 11, 2024 13:57
@netramali netramali requested a review from a team as a code owner April 11, 2024 13:57
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Let's just add a note about the change in the CHANGELOG just in case. Note that we're changing a beta field type as a Bug Fix.

@netramali
Copy link
Contributor Author

This is fine. Let's just add a note about the change in the CHANGELOG just in case. Note that we're changing a beta field type as a Bug Fix.

Added. Would it be possible for you to merge it since the tests on main branch are failing?

@brandonc brandonc merged commit 795fbf2 into main Apr 15, 2024
5 of 10 checks passed
@brandonc brandonc deleted the netramali/making-organization-scoped-pointer branch April 15, 2024 15:24
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants