[WAYP-2855] Enable execution mode option for creating no-code workspaces #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
reviewed
Jul 29, 2024
| @@ -68,6 +67,9 @@ type RegistryNoCodeModuleCreateWorkspaceOptions struct { | |||
|
|
|||
| // SourceUrl is the URL of the source of the workspace. | |||
| SourceURL *string `jsonapi:"attr,source-url,omitempty"` | |||
|
|
|||
| // ExecutionMode is the execution mode of the workspace. | |||
| ExecutionMode *string `jsonapi:"attr,execution-mode,omitempty"` | |||
There was a problem hiding this comment.
I think you'll also need to include AgentPoolID too, in case someone uses agent for its ExecutionMode?
paladin-devops
force-pushed
the
WAYP-2855-no-code-execution-mode
branch
from
e4a7858 to
1e22652
Compare
briancain
approved these changes
Jul 29, 2024
uturunku1
approved these changes
Jul 29, 2024
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option to set the execution mode of a Terraform no-code workspace when creating it.
Testing plan
Run
go-tfe go test -run TestRegistryNoCodeModule -v ./...with the necessary environment variables.