Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json encoding for vcs-repo request params when creating a Stack #946

Conversation

brandonc
Copy link
Collaborator

@brandonc brandonc commented Aug 1, 2024

Description

Use json encoding for vcs-repo request params when creating a Stack

Testing plan

This problem became apparent when using github-app-installation-id parmeter

stack1, err := client.Stacks.Create(ctx, StackCreateOptions{
    Name: "mm-test-stack",
    VCSRepo: &StackVCSRepo{
        Identifier:        "hashicorp/pet-nulls-stack",
        GHAInstallationID: "ghain-waqUDydU45bDADCe",
    },
    Project: &Project{
        ID: orgTest.DefaultProject.ID,
    },
})

Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@brandonc brandonc merged commit 217b7bf into main Aug 5, 2024
7 of 8 checks passed
@brandonc brandonc deleted the TF-19147-go-tfe-stacks-create-vcs-options-are-not-properly-encoded-as-request-params branch August 5, 2024 17:13
Copy link

github-actions bot commented Aug 5, 2024

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants