Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable redis-sentinel module #343

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Enable redis-sentinel module #343

wants to merge 8 commits into from
+590 −2

Conversation

sandrampeter
Copy link
Collaborator

@sandrampeter sandrampeter commented Dec 10, 2024 •
edited by jira bot
Loading

Background

TF-20056

The TFE (docker runtime) instance should connect directly to the Redis Sentinel cluster, no proxy is needed.

The on-prem Redis Sentinel cluster has:

  • 3 Sentinel nodes
  • 1 leader and 2 followers.

Docs added here :

https://hashicorp.atlassian.net/wiki/spaces/TE/pages/3249864755/How+to+deploy+TFE+in+Docker+and+on-prem+Redis+Sentinel+cluster+WIP

@sandrampeter sandrampeter requested a review from a team as a code owner December 10, 2024 14:56
@sandrampeter sandrampeter marked this pull request as draft December 10, 2024 14:56
@sandrampeter sandrampeter changed the title DRAFT: enable redis-sentinel module DRAFT: enable redis-sentinel module NOT TO BE MERGED Dec 10, 2024
@nikolasrieble nikolasrieble self-requested a review December 16, 2024 09:33
nikolasrieble
nikolasrieble reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@nikolasrieble nikolasrieble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you! I have but a few questions that are non blocking.

modules/redis-sentinel/compose.yaml Show resolved Hide resolved
modules/redis-sentinel/variables.tf Show resolved Hide resolved
@sandrampeter sandrampeter changed the title DRAFT: enable redis-sentinel module NOT TO BE MERGED Enable redis-sentinel module Dec 18, 2024
@sandrampeter sandrampeter marked this pull request as ready for review December 18, 2024 15:39
@sandrampeter sandrampeter requested review from nikolasrieble and a team January 9, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkerry jkerry jkerry approved these changes

@nikolasrieble nikolasrieble Awaiting requested review from nikolasrieble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandrampeter @jkerry @nikolasrieble