-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project level auto destroy #1550
Open
simonxmh
wants to merge
23
commits into
main
Choose a base branch
from
simonxmh/add_project_level_auto_destroy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonxmh
force-pushed
the
simonxmh/add_project_level_auto_destroy
branch
from
December 19, 2024 20:34
91a6fb5
to
01a4069
Compare
notchairmk
reviewed
Jan 3, 2025
notchairmk
reviewed
Jan 3, 2025
@@ -1,5 +1,13 @@ | |||
## Unreleased | |||
|
|||
BREAKING_CHANGES: | |||
* `r/tfe_workspace`: Add attribute `inherits_project_auto_destroy` to tfe_workspace, existing workspaces with auto-destroy settings should add `inherits_project_auto_destroy: false` to tfe_workspace resource [1550](https://github.com/hashicorp/terraform-provider-tfe/pull/1550) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should do fill this out for the user the same way we do on the frontend. Basically if they have one defined in config then we should automatically set this to false
notchairmk
reviewed
Jan 4, 2025
Add business org delegation to the datasource test Run go mod tidy Add interface stub Use datasource for organzation Reference data source Add missing reference Modify resource to directly reference orgname
simonxmh
force-pushed
the
simonxmh/add_project_level_auto_destroy
branch
from
January 9, 2025 21:33
15be161
to
54858bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support in the tfe provider for the project level ephemeral workspace settings.
Remember to:
Testing plan
/app/<orgname>/workspaces/<workspace_name>/settings/delete
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
Project Resource
Workspace Resource
Project Data source
Workspace Data source