Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Servant cookbooks part 1 (-testing + sqlite-simple) #1397

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Fixing Servant cookbooks part 1 (-testing + sqlite-simple) #1397

merged 2 commits into from
Mar 18, 2021

Conversation

akhesaCaro
Copy link
Contributor

@akhesaCaro akhesaCaro commented Mar 5, 2021 •
edited
Loading

The scope of this PR, as the others that will follow, is to fix servant cookbooks.

This PR make the project compiling and propose a first step through that goal.

Here are the tasks that have been made :

  • Fixing the network bug
  • Commenting servant-quickcheck cookbook which is trapped into a dependency loop for now (see this issue)
  • Fixing DocSpec failing test
  • Bringing sqlite-simple cookbook back to life

@akhesaCaro akhesaCaro force-pushed the compiling_sqlite_simple_cookbook branch from 26b46c0 to 2aa026d Compare March 5, 2021 10:28
@akhesaCaro akhesaCaro marked this pull request as ready for review March 5, 2021 10:30
@akhesaCaro akhesaCaro mentioned this pull request Mar 5, 2021
Closed
@gdeest gdeest mentioned this pull request Mar 16, 2021
Merged
@akhesaCaro akhesaCaro force-pushed the compiling_sqlite_simple_cookbook branch 3 times, most recently from c056c8c to d48c60d Compare March 18, 2021 06:38
@akhesaCaro akhesaCaro force-pushed the compiling_sqlite_simple_cookbook branch from d48c60d to ff9ad70 Compare March 18, 2021 07:49
gdeest
gdeest reviewed Mar 18, 2021
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
gdeest
gdeest reviewed Mar 18, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@akhesaCaro akhesaCaro force-pushed the compiling_sqlite_simple_cookbook branch from ff9ad70 to b01fc96 Compare March 18, 2021 09:49
@akhesaCaro akhesaCaro force-pushed the compiling_sqlite_simple_cookbook branch from b01fc96 to 269e546 Compare March 18, 2021 09:50
gdeest
gdeest approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@gdeest gdeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! :)

@gdeest gdeest merged commit 53e943b into haskell-servant:master Mar 18, 2021
@akhesaCaro akhesaCaro mentioned this pull request Mar 18, 2021
Merged
@akhesaCaro akhesaCaro deleted the compiling_sqlite_simple_cookbook branch March 18, 2021 10:15
akhesaCaro pushed a commit to akhesaCaro/servant that referenced this pull request Mar 18, 2021
@akhesaCaro
Merge pull request haskell-servant#1397 from akhesaCaro/compiling_sql…
fad1444 
…ite_simple_cookbook

Fixing Servant cookbooks part 1 (-testing + sqlite-simple)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdeest gdeest gdeest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhesaCaro @gdeest