Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align allocWorkBufffers to 32 bytes #57

Closed
wants to merge 1 commit into from

Conversation

jcberentsen
Copy link

Possible fix for #53

@jcberentsen
Copy link
Author

This particularly fixes the original #53 for me. Perhaps there are other places that should have the same alignment?

@newhoggy
Copy link
Member

newhoggy commented Oct 1, 2019

I'm inclined to think that if this works for you then that's all that is needed. The alignment is only needed when passed to C functions that make use of the SIMD instructions that require the alignment.

@newhoggy
Copy link
Member

newhoggy commented Oct 1, 2019

Can you check if the fix in this PR works?

#58

I prefer this version since the 32 isn't repeated reducing the opportunity for error.

@jcberentsen
Copy link
Author

Testing #58 works good on my end. I'll close this PR
Thank you for taking the time on this issue!

My usecase went from 3s down to 0.58s by computing the SIMD cursor!
The hw-json project is amazing!

@jcberentsen jcberentsen closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants