degrade gracefully if no git information available

haskell · Dec 31, 2024 · 7ceac05 · 7ceac05
1 parent 4c8ca38
commit 7ceac05
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 15 deletions.
diff --git a/Cabal/src/Distribution/Simple/Utils.hs b/Cabal/src/Distribution/Simple/Utils.hs
@@ -311,16 +311,18 @@ cabalVersion = mkVersion [3,0]  --used when bootstrapping
 
 -- |
 -- `Cabal` Git information. Only filled in if built in a Git tree in
--- developmnent mode and Template Haskell is available.
+-- development mode and Template Haskell is available.
 cabalGitInfo :: String
 #ifdef GIT_REV
-cabalGitInfo = concat [ "(commit "
-                      , giHash'
-                      , branchInfo
-                      , ", "
-                      , either (const "") giCommitDate gi'
-                      , ")"
-                      ]
+cabalGitInfo = if giHash' == ""
+                 then ""
+                 else concat [ "(commit "
+                             , giHash'
+                             , branchInfo
+                             , ", "
+                             , either (const "") giCommitDate gi'
+                             , ")"
+                             ]
   where
     gi' = $$tGitInfoCwdTry
     giHash' = take 7 . either (const "") giHash $ gi'

diff --git a/cabal-install/src/Distribution/Client/Version.hs b/cabal-install/src/Distribution/Client/Version.hs
@@ -33,13 +33,15 @@ cabalInstallVersion = mkVersion' PackageInfo.version
 -- developmnent mode and Template Haskell is available.
 cabalInstallGitInfo :: String
 #ifdef GIT_REV
-cabalInstallGitInfo = concat [ "(commit "
-                             , giHash'
-                             , branchInfo
-                             , ", "
-                             , either (const "") giCommitDate gi'
-                             , ")"
-                             ]
+cabalInstallGitInfo = if giHash' == ""
+                        then ""
+                        else concat [ "(commit "
+                                    , giHash'
+                                    , branchInfo
+                                    , ", "
+                                    , either (const "") giCommitDate gi'
+                                    , ")"
+                                    ]
   where
     gi' = $$tGitInfoCwdTry
     giHash' = take 7 . either (const "") giHash $ gi'