-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missed the two changelog pointers (backport #10138) #10139
Conversation
* missed the two changelog pointers * Apply suggestions from code review fixup! missed the two changelog pointers Co-authored-by: ffaf1 <[email protected]> * squash! and the other two changelogs --------- Co-authored-by: ffaf1 <[email protected]> (cherry picked from commit 82cad89)
Shall we merge it? What's the new conflict? |
The conflict was because of the glitch in 3.10.2.0's changelog entry (it got duplicated during 3.10.3.0 release). |
There's a problem in CI that didn't go away after restarting. Looks like a testsuite on branch master has bounds not updated in sync with the version bump to 3.13? |
It's a little complicated. Originally I updated that bound, but it caused build failures (essentially this same failure) so I had to back it out. I think that now, post-release, it has to be added again. |
My recollection is that this issue raises exactly when a release hits Hackage, so it's close to impossible to avoid it: if you bump the bound earlier, it will start failing, as Brandon suggests. I thought that we pin the index-state these days though. So maybe I'm wrong?.. |
Anyway, the obvious fix seems to work for Validate but fails doctests and some quick jobs, see #10172 |
* missed the two changelog pointers * Apply suggestions from code review fixup! missed the two changelog pointers Co-authored-by: ffaf1 <[email protected]> * squash! and the other two changelogs --------- Co-authored-by: ffaf1 <[email protected]> (cherry picked from commit 82cad89) Co-authored-by: brandon s allbery kf8nh <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* missed the two changelog pointers * Apply suggestions from code review fixup! missed the two changelog pointers Co-authored-by: ffaf1 <[email protected]> * squash! and the other two changelogs --------- Co-authored-by: ffaf1 <[email protected]> (cherry picked from commit 82cad89) Co-authored-by: brandon s allbery kf8nh <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Our release checklist is missing these files.
This is an automatic backport of pull request #10138 done by [Mergify](https://mergify.com).