-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make “sublibrary” standard terminology in docs #9371
Conversation
Previous related discussion here #8567 |
Let's just make sure we make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things occurred to me on reading these changes.
Substitute “internal library” occourrences with “sublibrary”.
fab4edb
to
dcae57f
Compare
dcae57f
to
af0d57a
Compare
I am going to merge this and rebase #9370. |
@mpilgrem: thanks a lot for the review and the merge. BTW, we tend to use a slower process for the merge to let people take note and voice last minute opinions: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions. |
We don't merge manually usually. The process is described here: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions Please, let's try to stick to the process. |
Sorry, I did not mean to rush things. As #9370 is closely related - and perhaps where there is more scope for divergent views - perhaps the debate there can cure my haste here. |
No harm done. :) |
Substitute “internal library” occourrences with “sublibrary”.
Note that:
hcar
documentation files, as they are versioned by date.file-format-changelog.rst
as it was appropriate.Template Β: This PR does not modify
cabal
behaviour (documentation, tests, refactoring, etc.)Include the following checklist in your PR: