Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make “sublibrary” standard terminology in docs #9371

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Oct 25, 2023

Substitute “internal library” occourrences with “sublibrary”.

Note that:

  • I did not touch hcar documentation files, as they are versioned by date.
  • I did update file-format-changelog.rst as it was appropriate.

Template Β: This PR does not modify cabal behaviour (documentation, tests, refactoring, etc.)

Include the following checklist in your PR:

@andreabedini
Copy link
Collaborator

Previous related discussion here #8567
Maybe let's wait to see if there is consensus.

@Mikolaj Mikolaj requested a review from mpilgrem October 26, 2023 11:12
@ffaf1 ffaf1 added the attention: needs-help Help wanted with this issue/PR label Oct 26, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Oct 26, 2023

Maybe let's wait to see if there is consensus.

Let's just make sure we make progress.

Copy link
Collaborator

@mpilgrem mpilgrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things occurred to me on reading these changes.

doc/cabal-package.rst Outdated Show resolved Hide resolved
doc/setup-commands.rst Outdated Show resolved Hide resolved
Substitute “internal library” occourrences with “sublibrary”.
@ffaf1 ffaf1 force-pushed the doc-internal-libraries branch from fab4edb to dcae57f Compare October 26, 2023 13:50
@ffaf1 ffaf1 force-pushed the doc-internal-libraries branch from dcae57f to af0d57a Compare October 26, 2023 13:56
@mpilgrem
Copy link
Collaborator

I am going to merge this and rebase #9370.

@mpilgrem mpilgrem merged commit a86ca8c into haskell:master Oct 26, 2023
42 checks passed
@Mikolaj
Copy link
Member

Mikolaj commented Oct 26, 2023

@mpilgrem: thanks a lot for the review and the merge. BTW, we tend to use a slower process for the merge to let people take note and voice last minute opinions: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions.

@ulysses4ever
Copy link
Collaborator

We don't merge manually usually. The process is described here: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions Please, let's try to stick to the process.

@mpilgrem
Copy link
Collaborator

Sorry, I did not mean to rush things. As #9370 is closely related - and perhaps where there is more scope for divergent views - perhaps the debate there can cure my haste here.

@Mikolaj
Copy link
Member

Mikolaj commented Oct 26, 2023

No harm done. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-help Help wanted with this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants