Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated api actions affecting groups store #136

Conversation

schellj
Copy link
Contributor

@schellj schellj commented Sep 4, 2020

Replaces deprecated api actions mpim.list and groups.info, which are affecting populating and using the data in the groups store when the Slack token was generated after July 10th. See #135.

I ran the test suite and it passed and I've tested manually with the change in this PR briefly and it seems to resolve the issue (though I just started using this app, so I'm not all that familiar with it yet). Let me know if you need anything else from me.

@theabhinavdas
Copy link

These changes are still not in master. Please merge. @schellj's fix works fine.

Thanks a ton @schellj 💯 🎉

@duynguyenhoang duynguyenhoang merged commit 323cd71 into haskellcamargo:master Sep 23, 2020
@duynguyenhoang
Copy link
Collaborator

Thanks @schellj for your PR

@schellj
Copy link
Contributor Author

schellj commented Sep 23, 2020

No problem, I'm happy to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants