Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unsetting offset. Fixes #123.
Methods
unset
,offsetUnset
andremove
now delete offset from data and cache array. I used 1. solution from here.We should now discuss if changing the interface is really such a breaking change. Are there actually any developers who actually implemented their own
AbstractConfig
? We can probably release as the minor/normal version, but just add in the release notes that interface is changed.