Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save schema SHA #546

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Save schema SHA #546

wants to merge 2 commits into from

Conversation

ajtritt
Copy link
Contributor

@ajtritt ajtritt commented Mar 23, 2021

Motivation

Store SHA of schema in files.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@ajtritt ajtritt requested review from rly and oruebel March 23, 2021 19:07
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #546 (089b22b) into dev (de33763) will decrease coverage by 1.84%.
The diff coverage is n/a.

❗ Current head 089b22b differs from pull request most recent head 7abe402. Consider uploading reports for the commit 7abe402 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #546      +/-   ##
==========================================
- Coverage   86.59%   84.74%   -1.85%     
==========================================
  Files          42       39       -3     
  Lines        8659     7900     -759     
  Branches     1868     1670     -198     
==========================================
- Hits         7498     6695     -803     
- Misses        832      876      +44     
  Partials      329      329              
Impacted Files Coverage Δ
src/hdmf/common/io/table.py 60.00% <0.00%> (-23.51%) ⬇️
src/hdmf/spec/spec.py 78.01% <0.00%> (-6.85%) ⬇️
src/hdmf/common/__init__.py 71.02% <0.00%> (-4.81%) ⬇️
src/hdmf/spec/namespace.py 83.81% <0.00%> (-3.76%) ⬇️
src/hdmf/validate/validator.py 80.47% <0.00%> (-3.48%) ⬇️
src/hdmf/data_utils.py 88.92% <0.00%> (-2.39%) ⬇️
src/hdmf/validate/errors.py 84.31% <0.00%> (-2.30%) ⬇️
src/hdmf/spec/catalog.py 92.66% <0.00%> (-1.89%) ⬇️
src/hdmf/build/manager.py 80.88% <0.00%> (-1.68%) ⬇️
src/hdmf/backends/hdf5/h5tools.py 81.42% <0.00%> (-0.66%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de33763...7abe402. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants