feat: add support for lsp workspace command arguments in prompt #12075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
A-language-server
MrLego8-9
force-pushed
the
add-support-for-lsp-command-args
branch
from
68d07ea to
0e03a66
Compare
Comment on lines
+1437
to
+1440
| let lsp_command_args: Vec<Value> = args[1..] | ||
| .iter() | ||
| .map(|s| Value::String(s.to_string())) | ||
| .collect(); |
There was a problem hiding this comment.
If we're parsing a list of JSON values then we should use the streaming deserializer from serde_json like #12527 does for :toggle-option. The streaming deserializer will take a slightly different syntax for strings - :lsp-workspace-command lsp.Command "foo" "bar" - which would be a breaking change to the syntax added if we merge this as-is.
I'll include this change on that PR since it's not possible to parse the args accurately with the way we parse the command line on master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat space-separated values as arguments in the prompt :
:lsp-workspace-command lsp.Command foo barTries to execute command
lsp.Commandwith the arguments [foo,bar] instead of executinglsp.Command foo bar.This allows users to run lsp commands that require arguments (ex: export* with tinymist).