Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix open_{below, above} behaviour with multiple cursors #12465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix open_{below, above} behaviour with multiple cursors #12465

wants to merge 1 commit into from
+126 −1

Conversation

TornaxO7
Copy link
Contributor

@TornaxO7 TornaxO7 commented Jan 9, 2025

Fixes #12448 and added some tests for them.

TL;DR: I deleted a variable (offs) in #12215 which I though wouldn't be useful but it was

hideThePain

Sorry for this.

@TornaxO7 TornaxO7 force-pushed the fix-open-above-and-below branch from 0014a88 to 4834cba Compare January 9, 2025 18:19
@TornaxO7 TornaxO7 mentioned this pull request Jan 9, 2025
Closed
archseer
archseer approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-mikedavis Should we consider cutting a patch release?

@RoloEdits
Copy link
Contributor

RoloEdits commented Jan 10, 2025 •
edited
Loading

If at all possible, perhaps deal with the glibc thing too before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open above and below are broken in multi-range selections
3 participants
@TornaxO7 @RoloEdits @archseer