Skip to content

Commit

Permalink
🧪 Uncommenting failing tests
Browse files Browse the repository at this point in the history
- In anticipation of fixing tests, but doesn't resolve them (#14)
  • Loading branch information
helmasaur committed Sep 2, 2023
1 parent cf1bddd commit c3da793
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ const assert = require('assert');

describe('zodiac.getSignByDate()', function() {
it('should get the zodiac sign\'s information based on a date', function() {
// assert.deepEqual(zodiac.getSignByDate(), zodiac.getSignByDate());
assert.deepEqual(zodiac.getSignByDate(), zodiac.getSignByDate());

it('should get the zodiac sign\'s information based on a date (French override)', function() {
// assert.deepEqual(zodiac.getSignByDate(undefined, 'fr'), zodiac.getSignByDate(), 'fr');
// assert.deepEqual(zodiac.getSignByDate(undefined, 'fr-FR'), zodiac.getSignByDate(), 'fr-FR');
assert.deepEqual(zodiac.getSignByDate(undefined, 'fr'), zodiac.getSignByDate(), 'fr');
assert.deepEqual(zodiac.getSignByDate(undefined, 'fr-FR'), zodiac.getSignByDate(), 'fr-FR');
});
});

Expand All @@ -28,12 +28,12 @@ describe('zodiac.getSignByDate(signDate)', function() {

describe('zodiac.getSignByName(signName)', function() {
it('should get the zodiac sign\'s information based on a name', function() {
//assert.deepEqual(zodiac.getSignByName('cancer'), { "name": "Cancer", "element": "water", "stone": "emerald", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
assert.deepEqual(zodiac.getSignByName('cancer'), { "name": "Cancer", "element": "water", "stone": "emerald", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
});

it('should get the zodiac sign\'s information based on a date (French override)', function() {
// assert.deepEqual(zodiac.getSignByName('cancer', 'fr'), { "name": "Cancer", "element": "eau", "stone": "émeraude", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
// assert.deepEqual(zodiac.getSignByName('cancer', 'fr-FR'), { "name": "Cancer", "element": "eau", "stone": "émeraude", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" }));
assert.deepEqual(zodiac.getSignByName('cancer', 'fr'), { "name": "Cancer", "element": "eau", "stone": "émeraude", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
assert.deepEqual(zodiac.getSignByName('cancer', 'fr-FR'), { "name": "Cancer", "element": "eau", "stone": "émeraude", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
});

it('should return the error code -1 when the name is invalid', function() {
Expand All @@ -48,9 +48,9 @@ describe('zodiac.getSignByName(signName)', function() {
});

describe('zodiac.getSignBySymbol(signSymbol)', function() {
// it('should get the zodiac sign\'s information based on a symbol', function() {
// assert.deepEqual(zodiac.getSignBySymbol('♋'), { "name": "Cancer", "element": "water", "stone": "emerald", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
// });
it('should get the zodiac sign\'s information based on a symbol', function() {
assert.deepEqual(zodiac.getSignBySymbol('♋'), { "name": "Cancer", "element": "water", "stone": "emerald", "symbol": "♋", "dateMin": "2000-06-22", "dateMax": "2000-07-22" });
});

it('should return the error code -1 when the symbol is invalid', function() {
assert.deepEqual(zodiac.getSignBySymbol('♾'), -2);
Expand Down

0 comments on commit c3da793

Please sign in to comment.