Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct test errors #14

Open
helmasaur opened this issue Jan 13, 2020 · 1 comment
Open

Correct test errors #14

helmasaur opened this issue Jan 13, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@helmasaur
Copy link
Owner

helmasaur commented Jan 13, 2020

The test file has been completed (#9) but undefined is returned for values which are linked through a key. It's the case for element.

The commented lines are the parts that have to be checked.

@helmasaur helmasaur added this to the v1.1.0 milestone Jan 13, 2020
@helmasaur helmasaur self-assigned this Jan 13, 2020
@helmasaur helmasaur modified the milestones: v1.4.0, v1.3.0 Apr 27, 2023
@helmasaur helmasaur modified the milestones: v1.3.0, v1.4.0 Aug 9, 2023
@helmasaur
Copy link
Owner Author

All tests issues but one is linked to the element file. It always returns undefined as an element. In a project, it works as expected, but not in tests. I think that the issue comes from the elements.json path from the test/test.js file.

Refer to #55 for the other issue.

helmasaur added a commit that referenced this issue Sep 2, 2023
- In anticipation of fixing tests, but doesn't resolve them (#14)
@helmasaur helmasaur modified the milestones: v1.4.0, v1.5.0 Sep 2, 2023
@helmasaur helmasaur modified the milestones: v1.5.0, 1.6.0 Nov 11, 2023
helmasaur added a commit that referenced this issue Jun 30, 2024
- xx-YY in overloads don't return an error due to b885acd (#55)
- some tests still don't pass (#14)
helmasaur added a commit that referenced this issue Jun 30, 2024
- xx-YY in overloads don't return an error due to b885acd (#55)
- some tests still don't pass (#14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant