-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added slice
argument for load_hdf5
#1753
base: main
Are you sure you want to change the base?
Conversation
Thank you for the PR! |
Thank you for the PR! |
Thank you for the PR! |
slice
argument for load_hdf5
Thank you for the PR! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
==========================================
- Coverage 92.26% 92.24% -0.02%
==========================================
Files 84 84
Lines 12445 12460 +15
==========================================
+ Hits 11482 11494 +12
- Misses 963 966 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Some users have expressed interest in only loading partial slices from an HDF5 dataset. This PR adds the
slices
argument toload_hdf5
, to allow dataset slicing like in the with theh5py
API. Removesload_fraction
argument to avoid redundancies.Due Diligence
Description
Issue/s resolved: #
Changes proposed:
load_hdf5
Type of change
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no