Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/777-argsort and testcase #966

Closed
wants to merge 7 commits into from

Conversation

GG-yuki
Copy link

@GG-yuki GG-yuki commented Apr 14, 2022

Description

add argsort and test case( not test yet due to device)

Issue/s resolved: #777

Changes proposed:

  • add argsort and testcase

Type of change

  • New feature

Memory requirements

Performance

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

@mtar
Copy link
Collaborator

mtar commented Apr 14, 2022

GPU cluster tests are currently disabled on this Pull Request.

@ghost
Copy link

ghost commented Apr 14, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@ClaudiaComito
Copy link
Contributor

@GG-yuki thanks a lot for this PR and apologies it's taken us so long to get back to you.

The tests are failing, do you need help with that?

Cheers,

Claudia

@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@ClaudiaComito
Copy link
Contributor

I'm going to close this PR, as the tests fail and it seems to need significantly more work. Will be addressed after merging #749 . Still, @GG-yuki thanks for the time you put into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement argsort
3 participants