Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: python prototype service #489

Merged
merged 24 commits into from
Feb 19, 2024
Merged

chore: python prototype service #489

merged 24 commits into from
Feb 19, 2024

Conversation

Paul-B98
Copy link
Contributor

Which issues does this pull request close?

closes #487

@Paul-B98 Paul-B98 requested a review from a team as a code owner October 25, 2023 16:20
@Paul-B98 Paul-B98 requested review from MaxSchaefer and florian-sabonchi and removed request for a team October 25, 2023 16:20
@Paul-B98 Paul-B98 self-assigned this Oct 25, 2023
@Paul-B98 Paul-B98 marked this pull request as draft October 25, 2023 16:37
@Paul-B98
Copy link
Contributor Author

I will add a GraphQL example in the near future. At the moment Strawberry is my preferred lib: https://strawberry.rocks/docs/integrations/django#async-django

@Paul-B98 Paul-B98 marked this pull request as ready for review November 25, 2023 21:30
@MaxSchaefer MaxSchaefer removed the request for review from florian-sabonchi December 7, 2023 22:27
MaxSchaefer
MaxSchaefer requested changes Dec 30, 2023
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we get rid of the services/impulse_svc/gen directory?
  • It seams like that libs/python handles djano so please rename this libe to to something like libs/hwdjano
  • Revisit the empty READMEs

libs/python/README.md Outdated Show resolved Hide resolved
libs/python/django_grpc/README.md Show resolved Hide resolved
@Paul-B98
Copy link
Contributor Author

Paul-B98 commented Jan 1, 2024

  • Can we get rid of the services/impulse_svc/gen directory?

Should be possible... I just have to find a goof way to package the gen code correctly.

  • It seams like that libs/python handles djano so please rename this libe to to something like libs/hwdjano

This was the result of our conversation where we made the decision that we create a language folder structure under lib like the gen folder.

@Paul-B98 Paul-B98 requested a review from MaxSchaefer January 11, 2024 18:44
MaxSchaefer
MaxSchaefer requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment •
edited by Paul-B98
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Green CI
  • Functional Docker Build of impulse_svc

@MaxSchaefer MaxSchaefer marked this pull request as draft January 24, 2024 22:21
@Paul-B98 Paul-B98 requested a review from MaxSchaefer February 9, 2024 20:09
@Paul-B98 Paul-B98 marked this pull request as ready for review February 9, 2024 20:09
@MaxSchaefer
Copy link
Member

@Paul-B98 green ci?

@MaxSchaefer MaxSchaefer changed the title Python prototype service chore: python prototype service Feb 19, 2024
@Paul-B98 Paul-B98 merged commit 27cd6c8 into main Feb 19, 2024
42 checks passed
@Paul-B98 Paul-B98 deleted the issue/487-python-prototype branch February 19, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxSchaefer MaxSchaefer MaxSchaefer approved these changes

Assignees

@Paul-B98 Paul-B98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python prototype service
2 participants
@Paul-B98 @MaxSchaefer