Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user-svc permissions #888

Merged
merged 23 commits into from
Dec 15, 2024
Merged

user-svc permissions #888

merged 23 commits into from
Dec 15, 2024

Conversation

FoseFx
Copy link
Member

@FoseFx FoseFx commented Nov 13, 2024 •
edited
Loading

Which issues does this pull request close?

Closes #877 (finally)

[OPTIONAL] Give testing instructions to reviewers

Adds

  • a small framework for spicedb migrations
  • migrations for spicedb (spicedb/migrations/5.go)
  • extends invites to be owned either by a user or an email
  • adds back references for users to their orgs (needs to be kept in sync manually!)
  • remove CreateUser rpc
  • deduplicate user-org adding
  • add permission checks for all missing user-svc rpcs

@FoseFx FoseFx force-pushed the issue/877-permissions-4 branch from 7af8324 to bd629b1 Compare November 21, 2024 12:38
@FoseFx FoseFx self-assigned this Dec 5, 2024
@FoseFx FoseFx changed the title Issue/877 permissions 4 user-svc permissions Dec 11, 2024
@FoseFx FoseFx marked this pull request as ready for review December 11, 2024 16:54
@FoseFx FoseFx requested a review from a team as a code owner December 11, 2024 16:55
@FoseFx FoseFx requested review from MaxSchaefer and removed request for a team December 11, 2024 16:55
@FoseFx FoseFx requested a review from PaulKalho December 11, 2024 16:55
MaxSchaefer
MaxSchaefer approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaxSchaefer
Copy link
Member

@FoseFx why the back refs from users to orgs?

@FoseFx
Copy link
Member Author

FoseFx commented Dec 15, 2024

@FoseFx why the back refs from users to orgs?

Needed here: https://github.com/helpwave/services/pull/888/files#diff-bfdd58a2cdee9c9728beee5556e3277d7df046dd92939358a293339746ea5e6bR12

@FoseFx FoseFx merged commit 96dc6f3 into main Dec 15, 2024
45 checks passed
@FoseFx FoseFx deleted the issue/877-permissions-4 branch December 15, 2024 16:53
FoseFx added a commit that referenced this pull request Dec 16, 2024
@FoseFx
user-svc permissions (#888)
04e0965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxSchaefer MaxSchaefer MaxSchaefer approved these changes

@PaulKalho PaulKalho Awaiting requested review from PaulKalho PaulKalho is a code owner automatically assigned from helpwave/backend

Assignees

@FoseFx FoseFx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permissions
2 participants
@FoseFx @MaxSchaefer