Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add avatar picture to TaskCard #779

Merged
merged 4 commits into from
Oct 22, 2023
Merged

add avatar picture to TaskCard #779

merged 4 commits into from
Oct 22, 2023

Conversation

DasProffi
Copy link
Member

Which issues does this pull request close?

closes #770

@DasProffi DasProffi self-assigned this Oct 22, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 22, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 11b7783
Status: ✅  Deploy successful!
Preview URL: https://fa338704.web-d91.pages.dev
Branch Preview URL: https://issue-770-avatar-icon-in-tas.web-d91.pages.dev

View logs

@felixevers felixevers changed the title add avtar picture to TaskCard add avatar picture to TaskCard Oct 22, 2023
@MaxSchaefer MaxSchaefer self-assigned this Oct 22, 2023
@MaxSchaefer MaxSchaefer force-pushed the issue/770-Avatar-icon-in-task-card branch 2 times, most recently from 282900c to 3375022 Compare October 22, 2023 19:07
@MaxSchaefer MaxSchaefer force-pushed the issue/770-Avatar-icon-in-task-card branch from 3375022 to f8e93ef Compare October 22, 2023 19:10
@MaxSchaefer MaxSchaefer changed the title add avatar picture to TaskCard feat: add avatar picture to TaskCard Oct 22, 2023
@felixevers
Copy link
Member

Depends on helpwave/services#484

@MaxSchaefer MaxSchaefer marked this pull request as ready for review October 22, 2023 19:23
@MaxSchaefer MaxSchaefer requested a review from a team as a code owner October 22, 2023 19:23
@MaxSchaefer MaxSchaefer requested review from MaxSchaefer and removed request for a team October 22, 2023 19:23
felixevers
felixevers reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@felixevers felixevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approval guaranteed atm...
Please update the package version on services increment.

tasks/mutations/user_mutations.ts Show resolved Hide resolved
felixevers
felixevers previously approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@felixevers felixevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Consider the comment above.

@DasProffi DasProffi changed the title feat: add avatar picture to TaskCard add avatar picture to TaskCard Oct 22, 2023
@MaxSchaefer MaxSchaefer merged commit 985eab4 into main Oct 22, 2023
9 checks passed
@DasProffi DasProffi deleted the issue/770-Avatar-icon-in-task-card branch July 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-sabonchi florian-sabonchi florian-sabonchi approved these changes

@felixevers felixevers felixevers approved these changes

@MaxSchaefer MaxSchaefer Awaiting requested review from MaxSchaefer MaxSchaefer is a code owner automatically assigned from helpwave/web

Assignees

@MaxSchaefer MaxSchaefer

@DasProffi DasProffi

Labels
proffi-proofed tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatar icon in task card
4 participants
@DasProffi @felixevers @MaxSchaefer @florian-sabonchi