Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase Nix flake PR #104

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Rebase Nix flake PR #104

merged 6 commits into from
Oct 27, 2023

Conversation

j-baker
Copy link
Contributor

@j-baker j-baker commented Oct 8, 2023

@koiuo this is the same as your PR, but with CI and a dev-shell setup. I also moved openssl into the buildInputs section of the dependencies, as it is a runtime dependency.

@j-baker j-baker mentioned this pull request Oct 8, 2023
Closed
@j-baker j-baker enabled auto-merge October 8, 2023 20:58
@j-baker j-baker requested a review from mara-schulke October 8, 2023 20:59
mara-schulke
mara-schulke approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@mara-schulke mara-schulke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the env file

.envrc Outdated Show resolved Hide resolved
@mara-schulke mara-schulke disabled auto-merge October 8, 2023 21:01
@mara-schulke mara-schulke added this to the Stabilization milestone Oct 10, 2023
@mara-schulke mara-schulke added complexity::low Issues or ideas with a low implementation cost integration Changes and ideas related to integrating buffrs with 3rd-party software or tools priority::medium This is not urgent, but we should do this. labels Oct 10, 2023
@koiuo
Copy link

koiuo commented Oct 11, 2023 •
edited
Loading

@j-baker re: runtime dependency

I believe rustls depends on openssl (can’t doublecheck from my phone) and cargo build fails when rustc reaches rustls if OpenSSL headers not available (at least on NixOS that’s the case, rustls’s cargo build script calls pkgconfig).

I’m not sure how crane works internally, but I’d conclude from this behavior that openssl is a build dependency.

UPDATE: sorry, was responding to the comment without checking the code.

@mara-schulke mara-schulke merged commit 818c6d6 into main Oct 27, 2023
7 checks passed
@mara-schulke mara-schulke deleted the jbaker/flake_redux branch October 27, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mara-schulke mara-schulke mara-schulke approved these changes

Assignees

@j-baker j-baker

Labels
complexity::low Issues or ideas with a low implementation cost integration Changes and ideas related to integrating buffrs with 3rd-party software or tools priority::medium This is not urgent, but we should do this.
Projects
Buffrs
Status: Done
Milestone
Stabilization
Development

Successfully merging this pull request may close these issues.
3 participants
@j-baker @koiuo @mara-schulke