Allow dependencies in Proto.lock
to be updated when manifest changes
#257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
buffrs install
to make changes to the lockfile when proto dependency versions were upgraded in the manifest.This code change is sufficient now because
buffrs
only support pinned versions in the manifest, so we can rely on the manifest always having the desired version. However, whenever we start supporting semantic version upgrades this logic might need to change.How I validated that my change works
[email protected]
to[email protected]
succeeded onbuffrs install
[email protected]
to[email protected]
succeeded onbuffrs install
Open Item
I wasn't able to load contents from cache in case we are ignoring the locked dependency and downloading a new version because
Cache
receives aFileRequirement
which can be created fromLockedPackage
but can't be created fromPackage
. I assume this could be fixed withimpl From<Package> for FileRequirement { ... }
.