Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support toml-parser-2.0.0.0 #8

Merged
merged 2 commits into from
Feb 27, 2024
Merged

support toml-parser-2.0.0.0 #8

merged 2 commits into from
Feb 27, 2024

Conversation

glguy
Copy link
Contributor

@glguy glguy commented Feb 27, 2024

No description provided.

@henrytill
Copy link
Owner

Thanks @glguy, very much appreciated!

I will go ahead and update the tests.

@henrytill
Copy link
Owner

You beat me to it! 😆

@glguy
Copy link
Contributor Author

glguy commented Feb 27, 2024

You beat me to it! 😆

Oops, I didn't see your message until after I fixed the tests up and came back to see if that fixed the build.

@henrytill
Copy link
Owner

Absolutely no problem, very much appreciated.

@glguy
Copy link
Contributor Author

glguy commented Feb 27, 2024

Before merging this you might consider adding something for making indexing into Tables easier. I had to make tables slightly more annoying to use than they were before in order to have a place to stash all the location annotations. The traversal valueAt defined in the tests now might be worth exporting from the main library (or something like it)

@henrytill
Copy link
Owner

Before merging this you might consider adding something for making indexing into Tables easier. I had to make tables slightly more annoying to use than they were before in order to have a place to stash all the location annotations. The traversal valueAt defined in the tests now might be worth exporting from the main library (or something like it)

Indeed, I had a similar intuition while looking at the changes.

I will probably go ahead and merge this PR as-is and then follow up with such a change before releasing to Hackage.

@henrytill henrytill merged commit b39cf54 into henrytill:master Feb 27, 2024
3 checks passed
@glguy glguy deleted the toml-2 branch February 27, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants