Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow username generator functions to check any incoming username. #75

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

zyro
Copy link
Member

@zyro zyro commented Dec 5, 2024

At the moment function signature for the username generator assumes it will always need to fire and return a fresh value, but this is not compatible with allowing initial account creations to set a custom username if they wish.

@zyro zyro requested a review from novabyte December 5, 2024 15:52
Copy link
Member

@novabyte novabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyro 👍

@zyro zyro merged commit 1bb6890 into main Dec 7, 2024
2 checks passed
@zyro zyro deleted the aim-username-generation branch December 7, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants