Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persian translation and fix direction #370

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

Erfankam
Copy link

Hi.
Persian translation has been done after get new updates by pull updates. Due to some messes in Persian views, I have also added some changes to detect lang direction and then change view direction based on detected direction thanks to RTL library.

Erfankam and others added 29 commits April 27, 2024 22:55
…extra edition. Extra edition is needed because of some punctuations and technical words.
@Erfankam Erfankam requested a review from a team as a code owner October 26, 2024 19:19
@Erfankam
Copy link
Author

Is there anybody out there to review and merge the PR?

@Erfankam
Copy link
Author

Is there anybody out there to review and merge the PR?

@sr @kennyp @alexmarnell @hone

@johlym
Copy link

johlym commented Jan 6, 2025

@Erfankam Happy new year!

Generally we're fans of having someone who's also fluent in the language to vouch for the changes. I'm not sure I could find someone over here that knows Persian well enough or at all to be helpful, here.

@Erfankam
Copy link
Author

Erfankam commented Jan 7, 2025

@johlym
Happy new year to you too.
Actually Persian is my first language. But if you are looking for whom is fluent in Persian, may I ask what kind of evidence or proof you need to accept some one as PR reviewer for language changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants