Skip to content

Commit

Permalink
Add explicit deprecations for Heroku 20 + 22, errors for 24
Browse files Browse the repository at this point in the history
  • Loading branch information
jason-salesforce committed May 30, 2024
1 parent cfcb226 commit 3a5d514
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# Change Log
All notable changes to this project will be documented in this file.

## [Unreleased]
## 2024-05-30
- Deprecates support in Heroku-22 and Heroku-20.
- Adds explicit error for Heroku-24

## 2022-05-19
- Added support for Heroku-22.
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
ARG BASE_IMAGE
FROM $BASE_IMAGE
USER root

ARG STACK
ARG GOOGLE_CHROME_CHANNEL
Expand Down
7 changes: 7 additions & 0 deletions bin/compile
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,14 @@ esac

# Install correct dependencies according to $STACK
case "${STACK}" in
"heroku-24")
error "This buildpack has reached end of life. Please use https://github.com/heroku/heroku-buildpack-chrome-for-testing"
;;
"heroku-18" | "heroku-20" | "heroku-22")
topic "###### WARNING ######"
topic "This buildpack is deprecated. Please use https://github.com/heroku/heroku-buildpack-chrome-for-testing"
topic "#####################"

# the package list is found by using ci:debug then running ldd $GOOGLE_CHROME_BIN | grep not
# also look here for more packages/notes https://developers.google.com/web/tools/puppeteer/troubleshooting
PACKAGES="
Expand Down

0 comments on commit 3a5d514

Please sign in to comment.