Remove try/catch & update tests

heroku · Sep 19, 2024 · bcc1c53 · bcc1c53
1 parent a6e4b03
commit bcc1c53
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/src/commands/ai/models/list.ts b/src/commands/ai/models/list.ts
@@ -1,6 +1,5 @@
 import {ux} from '@oclif/core'
 import {ModelList} from '../../../lib/ai/types'
-import {CLIError} from '@oclif/core/lib/errors'
 import Command from '../../../lib/base'
 
 const displayModels = (models: ModelList) => {
@@ -30,13 +29,8 @@ export default class List extends Command {
     const herokuAIClient = this.herokuAI
     const urlPath = '/available-models'
 
-    try {
-      const {body: availableModels} = await herokuAIClient.get<ModelList>(urlPath)
-      displayModels(availableModels)
-      ux.log('\nSee https://devcenter.heroku.com/articles/rainbow-unicorn-princess-models for more info.')
-    } catch (error) {
-      const {message} = error as CLIError
-      ux.error(message, {exit: 1})
-    }
+    const {body: availableModels} = await herokuAIClient.get<ModelList>(urlPath)
+    displayModels(availableModels)
+    ux.log('\nSee https://devcenter.heroku.com/articles/rainbow-unicorn-princess-models for more info.')
   }
 }
diff --git a/test/commands/ai/models/list.test.ts b/test/commands/ai/models/list.test.ts
@@ -47,11 +47,10 @@ describe('ai:models:list', function () {
     try {
       await runCommand(Cmd)
     } catch (error) {
-      const {message, oclif} = error as CLIError
+      const {message} = error as CLIError
       expect(stripAnsi(message)).to.contains('Failed to retrieve the list of available models.')
       expect(stripAnsi(message)).to.contains(statusURL)
       expect(stripAnsi(message)).to.contains(modelsDevCenterURL)
-      expect(oclif.exit).to.equal(1)
     }
   })
 })