Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Notebook 7 and Jupyter Lab #11

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

addisonwurtz
Copy link

Updated repository now launches either Jupyter Notebook 7 or Jupyter Lab on start up (based on env variable JUPYTER_NOTEBOOK_OR_LAB).

This PR includes breaking changes:

  • Jupyter Notebook versions < 7 are no longer supported.
  • I updated a fork of the dependency pgcontents in order to support notebook 7. This may break earlier versions. (I PR'd the original pgcontents repo, but it does not appear to be maintained anymore).

Copy link
Collaborator

@hillarysanders hillarysanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet sweet! Added a few commments

app.json Show resolved Hide resolved
app.json Outdated Show resolved Hide resolved
start_jupyter Outdated Show resolved Hide resolved
start_jupyter Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants