Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes the bit shift being performed on samples in the decoder write callback. The FLAC decoder library already ensures the samples are in the right range for the bit depth. After this change,
@divExact
produced a remainder, so that was changed to@divTruncate
, but that is possibly moot...I wrote a small Zig program to decode a 16-bit FLAC and count how many samples exceeded the max range for 16-bit numbers. It also writes all the samples to a text file:
As a reference, I wrote the same program in Go so I can diff the samples in the text file:
After removing the bit shift, there are no more bad samples and the samples are identical to the Go program:
The second commit adds support for 3 channels because...it was right there and it works :)
center.flac
now passes the sanity checks I demonstrated above.If needed, I can provided the code I used to check my work.