Changing resource category for textures in d3d12 issue #1225 #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed render_attachment = true from texture description in examples. Added power preference to adapter selection. Report adapter description. Report adapter type.
Fixing win32 so it passes zig build test.
emidoots
reviewed
Aug 8, 2024
examples/sprite/main.zig
Outdated
| @@ -16,5 +16,5 @@ pub fn main() !void { | |||
|
|
|||
| var app = try mach.App.init(allocator, .app); | |||
| defer app.deinit(allocator); | |||
| try app.run(.{ .allocator = allocator }); | |||
| try app.run(.{ .allocator = allocator, .power_preference = .high_performance }); | |||
There was a problem hiding this comment.
this should be the default so this change doesn't make sense.
There was a problem hiding this comment.
Yes, this slid in there by accident. I wanted to test with the discrete card on my computer.
The default power_preference is set to .undefined in the struct. To have an easy way to test at different settings it might be useful to include a build option, or have the examples support some standard command line arguments.
emidoots
reviewed
Aug 8, 2024
emidoots
reviewed
Aug 8, 2024
emidoots
reviewed
Aug 8, 2024
emidoots
approved these changes
Aug 8, 2024
fautore
pushed a commit
to fautore/mach
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing resource category for textures in d3d12 #1225