Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument of addCharacteristicToService for iOS #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix argument of addCharacteristicToService for iOS #10

wants to merge 1 commit into from

Conversation

Naturalclar
Copy link
Contributor

Fixed addCharacteristicToService to match the behavior of Android.

the value input for CBMutableCharacteristic should be nil so the value won't be cached and it can receive other values.
https://developer.apple.com/documentation/corebluetooth/cbmutablecharacteristic

@himelbrand
Copy link
Owner

looks good,
was it tested? and working?

@himelbrand
Copy link
Owner

looks good,
was it tested? and working?

@Naturalclar I don't have IOS to test it on

@Naturalclar
Copy link
Contributor Author

Sorry for late response!
I've checked that this fix will atleast not cause an error upon initializing, but there are other parts of this module that isn't working on iOS, so I'm working on a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naturalclar @himelbrand