This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Support Phantomas per metrics #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason github says we can't automatically merge it. |
In order to properly run get_fact_definitions, use a list of metrics defined in phantomas_info.py, which should be updated whenever a new Phantomas version is released.
|
I've rebased my work on top of the last commit and now I believe automerge will work. Try again please? |
heynemann
added a commit
that referenced
this pull request
Jan 3, 2014
Support Phantomas per metrics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt n.1: Support Phantomas per metrics
In order to properly run get_fact_definitions, use a list of metrics defined in phantomas_info.py, which should be updated whenever a new Phantomas version is released. Please read the line notes bellow.