Update to use app ws auth #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
changed the title
jost-s
approved these changes
Apr 26, 2024
| const issued = await adminWs.issueAppAuthenticationToken({ | ||
| installed_app_id: appInfo.installed_app_id, | ||
| }); | ||
| // This doesn't make a lot of sense... but we are asking the trycp server to create a connection, |
There was a problem hiding this comment.
Yeah, I guess a TryCP socket relay conundrum, like the attach and connect interface.
There was a problem hiding this comment.
Exactly that, it's not faithfully implementing the interface but actually doing something subtly different that is now very obvious from outside :/
Co-authored-by: Jost Schulte <[email protected]>
Co-authored-by: Jost Schulte <[email protected]>
Co-authored-by: Jost Schulte <[email protected]>
Co-authored-by: Jost Schulte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.