Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep admin connections open #221

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Keep admin connections open #221

merged 1 commit into from
Jul 17, 2024

Conversation

ThetaSinner
Copy link
Member

@ThetaSinner ThetaSinner commented Jul 16, 2024 •
edited
Loading

Closes #197

@ThetaSinner ThetaSinner requested review from neonphog and jost-s July 16, 2024 17:55
@ThetaSinner
Copy link
Member Author

Can't take another moment of looking at these logs ;)

neonphog
neonphog approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@ThetaSinner ThetaSinner merged commit 8e2cd6b into develop Jul 17, 2024
2 checks passed
@ThetaSinner ThetaSinner deleted the trycp-keep-admin-connections-open branch July 17, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonphog neonphog neonphog approved these changes

@jost-s jost-s Awaiting requested review from jost-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TryCP Server] Reuse admin websocket instead of connecting/disconnecting on every call
2 participants
@ThetaSinner @neonphog