-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on_keyup and value_input for code editor #6919
Conversation
Why not have a value_throttled instead? |
I see that sliders use value_throttled. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6919 +/- ##
==========================================
- Coverage 81.79% 81.75% -0.04%
==========================================
Files 326 327 +1
Lines 48350 48421 +71
==========================================
+ Hits 39546 39587 +41
- Misses 8804 8834 +30 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Philipp Rudiger <[email protected]>
This does end up being a fairly major change in behavior. I agree with it but still. |
Is there a way to have a flag that reverts back to the old version to smooth the transition? |
Or maybe it'd make sense to keep the current behavior with a flag that toggles the new behavior. |
I think this is a good suggestion to prevent breaking changes so I have implemented a flag that de-syncs |
Test failure seems unrelated
Oh might be https://www.githubstatus.com/ |
Closes #5486
Although this is a breaking change, I think it's worth it because if you try to bind a callback that runs the code from value, it triggers on every keystroke... and as you might imagine, writing valid code often requires more than one character change.
Previously, removing one character would trigger this error:
The workaround to this before is having a separate
pn.widgets.Button
to submit the code, but now, users can simply watchvalue
, or if they want to watch on every keystrokevalue_input