Introduce RingFilter and RingElementFilter #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 439 439
Lines 72188 72200 +12
=======================================
+ Hits 50945 50955 +10
- Misses 21243 21245 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mohamed-barakat
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more or less corresponds to
CategoryFilterandObjectFilteretc. in CAP and is needed to handle commutative rings of linear categories in a clean way in CAP. Note: I have not covered all homalg rings. If you want to cover more rings, maybe we can do this together. If a ring is not covered, CAP will simply fall back toIsRingandIsRingElement, so the type checking is less strict, but nothing breaks.