Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change icon links to svg and new repo in integration.ts #2008

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

toineenzo
Copy link
Contributor

@toineenzo toineenzo commented Jan 18, 2025


Homarr

Depends on homarr-labs/dashboard-icons#911

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@toineenzo toineenzo requested a review from a team as a code owner January 18, 2025 14:22
@toineenzo
Copy link
Contributor Author

Just another small change to keep everything consistent :)
Perhaps change these links to svg versions?

Copy link

deepsource-io bot commented Jan 18, 2025

Here's the code health analysis summary for commits fa6262c..4f5ca14. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Meierschlumpf
Meierschlumpf previously approved these changes Jan 18, 2025
@Meierschlumpf
Copy link
Member

Just another small change to keep everything consistent :) Perhaps change these links to svg versions?

Yeah svgs might be a better idea 👍🏼

manuel-rw
manuel-rw previously approved these changes Jan 18, 2025
@toineenzo toineenzo changed the title Change one icon link in integration.ts that used old repo Change icon links to svg and new repo in integration.ts Jan 18, 2025
@toineenzo toineenzo dismissed stale reviews from manuel-rw and Meierschlumpf via 76c35a3 January 18, 2025 17:17
@toineenzo
Copy link
Contributor Author

Dashdot, Tdarr and NZBget don't have a svg variant in the dashboard-icons repo. Ill try to add them

manuel-rw
manuel-rw previously approved these changes Jan 18, 2025
@manuel-rw manuel-rw added the enhancement New feature or request label Jan 18, 2025
Meierschlumpf
Meierschlumpf previously approved these changes Jan 18, 2025
@toineenzo
Copy link
Contributor Author

PR for NZBget svg icon: homarr-labs/dashboard-icons#911
I posted in the Dash. and Tdarr Discord to see if a SVG icon is available.

@toineenzo toineenzo dismissed stale reviews from Meierschlumpf and manuel-rw via 4f5ca14 January 18, 2025 18:01
@toineenzo toineenzo changed the title Change icon links to svg and new repo in integration.ts chore: Change icon links to svg and new repo in integration.ts Jan 21, 2025
@Meierschlumpf
Copy link
Member

Hey
As our current focus is on polishing Homarr 1.0 and this is not the most important thing to be merged, I suggest that we leave it open and merge it ones we have also setup a better workflow for adding icons to the dashboard-icons repository that automatically adds svg / png / webp and does not always regenerate all icons which results in so many merge conflicts. This means that this PR will be merged in about a month I guess. Hope thats okay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants